[stable32] fix(theming): display error messages on image upload and delete previous image only after validation#58322
Open
backportbot[bot] wants to merge 2 commits intostable32from
Open
[stable32] fix(theming): display error messages on image upload and delete previous image only after validation#58322backportbot[bot] wants to merge 2 commits intostable32from
backportbot[bot] wants to merge 2 commits intostable32from
Conversation
backportbot
bot
requested review from
cristianscheid,
provokateurin,
susnux and
szaimen
…ous image only after validation Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
cristianscheid
requested review from
Altahrim,
ArtificialOwl and
icewind1991
and removed request for
a team
cristianscheid
approved these changes
Feb 13, 2026
provokateurin
requested changes
Feb 16, 2026
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
What about the frontend changes?
Contributor
@provokateurin Sorry, forgot to mention this here, but frontend changes are not required for stable32. The current implementation already handles the server response properly and displays the appropriate message to users. I've retested to confirm it works as expected: 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #58003
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.